Closed
Bug 1629427
Opened 5 years ago
Closed 5 years ago
TestRollingNumber.cpp: use unary 'static_assert' when the string literal is an empty string
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox77 fixed)
RESOLVED
FIXED
mozilla77
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: scfocus, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
, ""); at the end of static_assert is useless
https://searchfox.org/mozilla-central/source/dom/media/doctor/gtest/TestRollingNumber.cpp#20
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/modernize-unary-static-assert.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Also, please only work on two max of such bugs.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9140952 -
Attachment description: Bug 1629427 → fix static_assert
|
|
||
Updated•5 years ago
|
Attachment #9140952 -
Attachment description: fix static_assert → Bug static_assert_rm_extra_symbol
|
|
||
Updated•5 years ago
|
Attachment #9140952 -
Attachment description: Bug static_assert_rm_extra_symbol → Bug 1629427 static_assert rm extra symbol
|
|
||
Updated•5 years ago
|
Attachment #9140952 -
Attachment description: Bug 1629427 static_assert rm extra symbol → Bug 1629427 static_assert remove extra symbol
|
|
||
Updated•5 years ago
|
Attachment #9140952 -
Attachment description: Bug 1629427 static_assert remove extra symbol → Bug 1629427 - static_assert remove extra symbol
|
|
||
Updated•5 years ago
|
Attachment #9140952 -
Attachment description: Bug 1629427 - static_assert remove extra symbol → Bug 1629427 - static_assert remove extra symbol. r?sylvestre
|
|
||
Updated•5 years ago
|
Assignee: nobody → scfocus
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe7c26093c48
static_assert remove extra symbol. r=sylvestre
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•